From 13427fc603b4d6b83ba7002484aed77aaed4c7fa Mon Sep 17 00:00:00 2001 From: Antony Dovgal Date: Tue, 5 Sep 2006 10:35:53 +0000 Subject: [PATCH] fix segfaulting typo in dcngettext() =) add new test --- ext/gettext/gettext.c | 2 +- ext/gettext/tests/dcngettext.phpt | 30 ++++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 ext/gettext/tests/dcngettext.phpt diff --git a/ext/gettext/gettext.c b/ext/gettext/gettext.c index 8cd04c4bcd..79999e5890 100644 --- a/ext/gettext/gettext.c +++ b/ext/gettext/gettext.c @@ -327,7 +327,7 @@ PHP_NAMED_FUNCTION(zif_dcngettext) RETVAL_FALSE; - if (ZEND_NUM_ARGS() != 5 || zend_get_parameters_ex(4, &domain, &msgid1, &msgid2, &count, &category) == FAILURE) { + if (ZEND_NUM_ARGS() != 5 || zend_get_parameters_ex(5, &domain, &msgid1, &msgid2, &count, &category) == FAILURE) { WRONG_PARAM_COUNT; } else { char* msgstr = NULL; diff --git a/ext/gettext/tests/dcngettext.phpt b/ext/gettext/tests/dcngettext.phpt new file mode 100644 index 0000000000..e5961eb1e9 --- /dev/null +++ b/ext/gettext/tests/dcngettext.phpt @@ -0,0 +1,30 @@ +--TEST-- +dcngettext() tests +--SKIPIF-- + +--FILE-- + +--EXPECTF-- +Warning: Wrong parameter count for dcngettext() in %s on line %d +bool(false) +string(1) "1" +string(4) "test" +string(4) "test" +string(4) "test" +string(0) "" +string(0) "" +Done -- 2.50.1