From 1184da191cc67ca54332a374ddd448011e15d0d4 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 3 Oct 2016 04:48:22 +0000 Subject: [PATCH] [lit] Throw in unimplemented method (NFC) Summary: lit's `OneCommandFileTest` class implements an abstract method that raises if called. However, it raises by referencing an undefined symbol. Instead, raise explicitly by throwing a `NotImplementedError`. This is clearer, and appeases Python linters. Patch By Brian Gesiak! Reviewers: ddunbar, echristo, beanz Subscribers: llvm-commits, mehdi_amini Differential Revision: https://reviews.llvm.org/D25170 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@283090 91177308-0d34-0410-b5e6-96231b3b80d8 --- utils/lit/lit/formats/base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/lit/lit/formats/base.py b/utils/lit/lit/formats/base.py index 3d305cca5fc..6721d17e334 100644 --- a/utils/lit/lit/formats/base.py +++ b/utils/lit/lit/formats/base.py @@ -80,7 +80,7 @@ class OneCommandPerFileTest(TestFormat): yield test def createTempInput(self, tmp, test): - abstract + raise NotImplementedError('This is an abstract method.') def execute(self, test, litConfig): if test.config.unsupported: -- 2.50.1