From 113aa2339de35ce4fe7d1e045ffe08afdb7232e6 Mon Sep 17 00:00:00 2001 From: Dmitry Stogov Date: Tue, 9 Jan 2007 16:27:32 +0000 Subject: [PATCH] Close open files in case of failure (Amit) --- ext/standard/proc_open.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/ext/standard/proc_open.c b/ext/standard/proc_open.c index 2648dfbb2b..7a97599e51 100644 --- a/ext/standard/proc_open.c +++ b/ext/standard/proc_open.c @@ -748,6 +748,13 @@ PHP_FUNCTION(proc_open) } if (FALSE == newprocok) { + /* clean up all the descriptors */ + for (i = 0; i < ndesc; i++) { + CloseHandle(descriptors[i].childend); + if (descriptors[i].parentend) { + CloseHandle(descriptors[i].parentend); + } + } php_error_docref(NULL TSRMLS_CC, E_WARNING, "CreateProcess failed"); goto exit_fail; } -- 2.50.1