From 111b8ca02fff3854ddda04e7ed1ffe1e8d746c16 Mon Sep 17 00:00:00 2001 From: Felipe Pena Date: Fri, 21 Nov 2008 22:26:49 +0000 Subject: [PATCH] - Fixed memory leak in readline_callback_handler_remove() --- ext/readline/readline.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ext/readline/readline.c b/ext/readline/readline.c index 185492645b..29880a8af5 100644 --- a/ext/readline/readline.c +++ b/ext/readline/readline.c @@ -551,7 +551,8 @@ PHP_FUNCTION(readline_callback_handler_install) if (_prepped_callback) { rl_callback_handler_remove(); - zval_ptr_dtor(&_prepped_callback); + zval_dtor(_prepped_callback); + FREE_ZVAL(_prepped_callback); } MAKE_STD_ZVAL(_prepped_callback); @@ -580,6 +581,7 @@ PHP_FUNCTION(readline_callback_handler_remove) { if (_prepped_callback) { rl_callback_handler_remove(); + zval_dtor(_prepped_callback); FREE_ZVAL(_prepped_callback); _prepped_callback = 0; RETURN_TRUE; -- 2.40.0