From 10bb84a018cdea61243023f8759d35daf64aa3ea Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Sun, 17 Jul 2022 15:16:17 -0700 Subject: [PATCH] gvc: remove unused 'gvevent_modify' The `modify` field was added to `gvdevice_callbacks_t` in 50df9e82edcb61c5650f81ca317a31c9493ed07e, but seemingly has never been used by any in-tree plugin. This commit removes a no-op, never-called callback for it, squashing some -Wunused-parameter warnings. This commit does not remove the member because it is part of the public API. We are assuming the convention is to check these pointers against null before calling them, like the other GVC structs. But the struct has no comment explaining it nor how it is meant to be used, so we cannot be sure how/if users would be relying on this. --- lib/gvc/gvevent.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lib/gvc/gvevent.c b/lib/gvc/gvevent.c index 333abd9d2..8cbaf4ec5 100644 --- a/lib/gvc/gvevent.c +++ b/lib/gvc/gvevent.c @@ -545,11 +545,6 @@ static int toggle_fit_cb(GVJ_t * job) return 0; } -static void gvevent_modify (GVJ_t * job, const char *name, const char *value) -{ - /* FIXME */ -} - static void gvevent_delete (GVJ_t * job) { /* FIXME */ @@ -653,7 +648,7 @@ gvdevice_callbacks_t gvdevice_callbacks = { gvevent_button_press, gvevent_button_release, gvevent_motion, - gvevent_modify, + NULL, // modify gvevent_delete, gvevent_read, gvevent_layout, -- 2.40.0