From 10b2675d6e79ad76f2b74c569f4cf1a716a904c1 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 29 Apr 2019 08:44:51 +0200 Subject: [PATCH] Fix potential catalog corruption with temporary identity columns If a temporary table with an identity column and ON COMMIT DROP is created in a single-statement transaction (not useful, but allowed), it would leave the catalog corrupted. We need to add a CommandCounterIncrement() so that PreCommit_on_commit_actions() sees the created dependency between table and sequence and can clean it up. The analogous and more useful case of doing this in a transaction block already runs some CommandCounterIncrement() before it gets to the on-commit cleanup, so it wasn't a problem in practical use. Several locations for placing the new CommandCounterIncrement() call were discussed. This patch places it at the end of standard_ProcessUtility(). That would also help if other commands were to create catalog entries that some on-commit action would like to see. Bug: #15631 Reported-by: Serge Latyntsev Author: Peter Eisentraut Reviewed-by: Michael Paquier --- src/backend/tcop/utility.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/backend/tcop/utility.c b/src/backend/tcop/utility.c index 75faf37a71..9e195891ce 100644 --- a/src/backend/tcop/utility.c +++ b/src/backend/tcop/utility.c @@ -935,6 +935,13 @@ standard_ProcessUtility(PlannedStmt *pstmt, } free_parsestate(pstate); + + /* + * Make effects of commands visible, for instance so that + * PreCommit_on_commit_actions() can see them (see for example bug + * #15631). + */ + CommandCounterIncrement(); } /* -- 2.40.0