From 0f9133b66b567312f23e39eb767d6e6546aa590d Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Fri, 26 Jul 2019 17:46:40 -0400 Subject: [PATCH] Don't uselessly escape a string that doesn't need escaping Per gripe from Ian Barwick Co-authored-by: Ian Barwick Discussion: https://postgr.es/m/CABvVfJWNnNKb8cHsTLhkTsvL1+G6BVcV+57+w1JZ61p8YGPdWQ@mail.gmail.com --- src/bin/pg_basebackup/pg_basebackup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c index ef1b63bc7b..a783d63df7 100644 --- a/src/bin/pg_basebackup/pg_basebackup.c +++ b/src/bin/pg_basebackup/pg_basebackup.c @@ -1555,9 +1555,9 @@ GenerateRecoveryConf(PGconn *conn) if (replication_slot) { - escaped = escape_quotes(replication_slot); - appendPQExpBuffer(recoveryconfcontents, "primary_slot_name = '%s'\n", replication_slot); - free(escaped); + /* unescaped: ReplicationSlotValidateName allows [a-z0-9_] only */ + appendPQExpBuffer(recoveryconfcontents, "primary_slot_name = '%s'\n", + replication_slot); } if (PQExpBufferBroken(recoveryconfcontents) || -- 2.40.0