From 0d0c20797a0cf2937886945f3aecc4e8a9a55e8c Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Sun, 19 Jun 2022 09:15:55 -0700 Subject: [PATCH] CI: make UBSan errors fatal in sanitizer job When enabling ASan and UBSan, ASan defaults to aborting execution on a detected error while UBSan defaults to a warning and then continuing. The effect of this is that any UBSan issues go unnoticed in CI when no one is monitoring stderr. This change makes UBSan issues also have abort behavior. Gitlab: fixes #2200 --- .gitlab-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 43558ee3b..32a5c15e5 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -755,8 +755,8 @@ ubuntu22-04-cmake-ASan-build-for-ctest: before_script: - export build_system="cmake" # fail on any compiler warnings - - export CFLAGS="-fsanitize=address,undefined -g -Werror" - - export CXXFLAGS="-fsanitize=address,undefined -g -Werror" + - export CFLAGS="-fsanitize=address,undefined -fno-sanitize-recover=address,undefined -g -Werror" + - export CXXFLAGS="-fsanitize=address,undefined -fno-sanitize-recover=address,undefined -g -Werror" - export CMAKE_OPTIONS="-Duse_coverage=ON -Dwith_cxx_tests=ON -Dwith_cxx_api=ON" - export CMAKE_OPTIONS="$CMAKE_OPTIONS -Dwith_smyrna=ON" # override the deb_build_definition artifacts since we need more -- 2.50.1