From 0c991ec57a12e3196b934d9b46b8b5ec69ac645c Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Mon, 21 Jul 2014 08:32:31 +0000 Subject: [PATCH] [SDAG] Rather than using a narrow test against the one dummy node on the stack, filter all handle nodes from the DAG combiner worklist. This will also handle cases where other handle nodes might be (erroneously) added to the worklist and then cause bugs and explosions when deleted. For example, when running the legalizer within the DAG combiner, there are times when other handle nodes are used and can end up here. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@213505 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/SelectionDAG/DAGCombiner.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/lib/CodeGen/SelectionDAG/DAGCombiner.cpp index 2bed93b0dff..c3020f81734 100644 --- a/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -127,6 +127,11 @@ namespace { /// AddToWorkList - Add to the work list making sure its instance is at the /// back (next to be processed.) void AddToWorkList(SDNode *N) { + // Skip handle nodes as they can't usefully be combined and confuse the + // zero-use deletion strategy. + if (N->getOpcode() == ISD::HANDLENODE) + return; + WorkListContents.insert(N); WorkListOrder.push_back(N); } @@ -1108,7 +1113,7 @@ void DAGCombiner::Run(CombineLevel AtLevel) { // If N has no uses, it is dead. Make sure to revisit all N's operands once // N is deleted from the DAG, since they too may now be dead or may have a // reduced number of uses, allowing other xforms. - if (N->use_empty() && N != &Dummy) { + if (N->use_empty()) { for (unsigned i = 0, e = N->getNumOperands(); i != e; ++i) AddToWorkList(N->getOperand(i).getNode()); -- 2.40.0