From 0baf2d9383f5846624cf6e38cede1d57c6422cc2 Mon Sep 17 00:00:00 2001 From: Graham Leggett Date: Sat, 27 Apr 2013 17:08:22 +0000 Subject: [PATCH] mod_dav: PROPPATCH delete (svn propdel) silently discards errors. PR 53525 Submitted by Arwin Arni git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1476627 13f79535-47bb-0310-9956-ffa450edef68 --- CHANGES | 3 +++ modules/dav/main/props.c | 6 ++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/CHANGES b/CHANGES index 9d40d2498a..88b2af112c 100644 --- a/CHANGES +++ b/CHANGES @@ -1,6 +1,9 @@ -*- coding: utf-8 -*- Changes with Apache 2.5.0 + *) mod_dav: PROPPATCH delete (svn propdel) silently discards errors. + PR 53525 [Arwin Arni ] + *) mod_dav: Ensure URI is correctly uriencoded on return. PR 54611 [Timothy Wood ] diff --git a/modules/dav/main/props.c b/modules/dav/main/props.c index d87dd61131..19c7b11aef 100644 --- a/modules/dav/main/props.c +++ b/modules/dav/main/props.c @@ -1042,11 +1042,9 @@ DAV_DECLARE_NONSTD(void) dav_prop_exec(dav_prop_ctx *ctx) else if (ctx->operation == DAV_PROP_OP_DELETE) { /* - ** Delete the property. Ignore errors -- the property is there, or - ** we are deleting it for a second time. + ** Delete the property. */ - /* ### but what about other errors? */ - (void) (*propdb->db_hooks->remove)(propdb->db, &name); + err = (*propdb->db_hooks->remove)(propdb->db, &name); } } -- 2.40.0