From 0b687baf9f903d3ada2f73b224e2bfa5418fc64d Mon Sep 17 00:00:00 2001 From: Richard Smith Date: Tue, 10 Sep 2019 00:39:53 +0000 Subject: [PATCH] Fix crash mangling an explicit lambda non-type template parameter pack that is not a pack expansion. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@371476 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/AST/ItaniumMangle.cpp | 3 ++- test/CodeGenCXX/mangle-lambda-explicit-template-params.cpp | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/AST/ItaniumMangle.cpp b/lib/AST/ItaniumMangle.cpp index 2a2b491bcb..66bccbe458 100644 --- a/lib/AST/ItaniumMangle.cpp +++ b/lib/AST/ItaniumMangle.cpp @@ -1704,7 +1704,8 @@ void CXXNameMangler::mangleTemplateParamDecl(const NamedDecl *Decl) { QualType T = Tn->getType(); if (Tn->isParameterPack()) { Out << "Tp"; - T = T->castAs()->getPattern(); + if (auto *PackExpansion = T->getAs()) + T = PackExpansion->getPattern(); } Out << "Tn"; mangleType(T); diff --git a/test/CodeGenCXX/mangle-lambda-explicit-template-params.cpp b/test/CodeGenCXX/mangle-lambda-explicit-template-params.cpp index dba10fbf01..45fdec30f9 100644 --- a/test/CodeGenCXX/mangle-lambda-explicit-template-params.cpp +++ b/test/CodeGenCXX/mangle-lambda-explicit-template-params.cpp @@ -54,6 +54,12 @@ inline void collision() { } void use_collision() { collision(); } +namespace pack_not_pack_expansion { + template struct X; + // CHECK: @_ZNK23pack_not_pack_expansion1xMUlTyTtTyTnT_TpTnTL0__ETpTyvE_clIiNS_1XEJfEEEDav + inline auto x = [] typename, typename ...V>(){}; void f() { x.operator()(); } +} + template void f() { // CHECK: define linkonce_odr {{.*}} @_ZZ1fIiEvvENKUlT_E_clIiEEDaS0_( auto x = [](auto){}; -- 2.50.1