From 09c4a7dee2eb39b515e5f499f184257cdbe9cb42 Mon Sep 17 00:00:00 2001 From: Ned Deily Date: Sat, 26 May 2018 16:30:46 -0400 Subject: [PATCH] bpo-33655: Also ignore test_posix_fallocate failures on BSD platforms (GH-7134) The failure may be due to the use oF ZFS, a case we already ignore for Solaris-based systems where ZFS is frequently used. --- Lib/test/test_posix.py | 7 ++++++- .../next/Tests/2018-05-26-16-01-40.bpo-33655.Frb4LA.rst | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 Misc/NEWS.d/next/Tests/2018-05-26-16-01-40.bpo-33655.Frb4LA.rst diff --git a/Lib/test/test_posix.py b/Lib/test/test_posix.py index ecf3e93eb0..e54484ce7d 100644 --- a/Lib/test/test_posix.py +++ b/Lib/test/test_posix.py @@ -343,7 +343,12 @@ class PosixTester(unittest.TestCase): except OSError as inst: # issue10812, ZFS doesn't appear to support posix_fallocate, # so skip Solaris-based since they are likely to have ZFS. - if inst.errno != errno.EINVAL or not sys.platform.startswith("sunos"): + # issue33655: Also ignore EINVAL on *BSD since ZFS is also + # often used there. + if inst.errno == errno.EINVAL and sys.platform.startswith( + ('sunos', 'freebsd', 'netbsd', 'openbsd', 'gnukfreebsd')): + raise unittest.SkipTest("test may fail on ZFS filesystems") + else: raise finally: os.close(fd) diff --git a/Misc/NEWS.d/next/Tests/2018-05-26-16-01-40.bpo-33655.Frb4LA.rst b/Misc/NEWS.d/next/Tests/2018-05-26-16-01-40.bpo-33655.Frb4LA.rst new file mode 100644 index 0000000000..7ed2ea2323 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2018-05-26-16-01-40.bpo-33655.Frb4LA.rst @@ -0,0 +1,2 @@ +Ignore test_posix_fallocate failures on BSD platforms that might be due to +running on ZFS. -- 2.40.0