From 0967d695fa73ee6e58ca88cebbec080a949f0d03 Mon Sep 17 00:00:00 2001 From: Johannes Doerfert Date: Fri, 16 Aug 2019 21:55:01 +0000 Subject: [PATCH] [Attributor] Fix: Make sure we set the changed flag The flag was updated *before* we actually run the visitor callback so we might miss updates. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369159 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/IPO/Attributor.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/Transforms/IPO/Attributor.cpp b/lib/Transforms/IPO/Attributor.cpp index 4339a65f5e6..882d0931f9f 100644 --- a/lib/Transforms/IPO/Attributor.cpp +++ b/lib/Transforms/IPO/Attributor.cpp @@ -878,7 +878,7 @@ ChangeStatus AAReturnedValuesImpl::updateImpl(Attributor &A) { // The map in which we collect return values -> return instrs. decltype(ReturnedValues) &RetValsMap; // The flag to indicate a change. - bool Changed; + bool &Changed; // The return instrs we come from. SmallPtrSet RetInsts; }; @@ -906,9 +906,8 @@ ChangeStatus AAReturnedValuesImpl::updateImpl(Attributor &A) { // Callback for all "return intructions" live in the associated function. auto CheckReturnInst = [this, &VisitReturnedValue, &Changed](Instruction &I) { ReturnInst &Ret = cast(I); - RVState RVS({ReturnedValues, false, {}}); + RVState RVS({ReturnedValues, Changed, {}}); RVS.RetInsts.insert(&Ret); - Changed |= RVS.Changed; return VisitReturnedValue(*Ret.getReturnValue(), RVS); }; @@ -955,7 +954,8 @@ ChangeStatus AAReturnedValuesImpl::updateImpl(Attributor &A) { if (Argument *Arg = dyn_cast(RetVal)) { // Arguments are mapped to call site operands and we begin the traversal // again. - RVState RVS({NewRVsMap, false, RetValAAIt.second}); + bool Unused; + RVState RVS({NewRVsMap, Unused, RetValAAIt.second}); VisitReturnedValue(*CB->getArgOperand(Arg->getArgNo()), RVS); continue; } else if (isa(RetVal)) { -- 2.40.0