From 0962182f01c1e29417b016a82c7947697daba82b Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 3 Sep 2011 16:17:44 -0400 Subject: [PATCH] Fix typo in pg_srand48 (srand48 in older branches). ">" should be ">>". This typo results in failure to use all of the bits of the provided seed. This might rise to the level of a security bug if we were relying on srand48 for any security-critical purposes, but we are not --- in fact, it's not used at all unless the platform lacks srandom(), which is improbable. Even on such a platform the exposure seems minimal. Reported privately by Andres Freund. --- src/port/erand48.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/port/erand48.c b/src/port/erand48.c index ce623e2e96..3ed0193ef9 100644 --- a/src/port/erand48.c +++ b/src/port/erand48.c @@ -92,7 +92,7 @@ srand48(long seed) { _rand48_seed[0] = RAND48_SEED_0; _rand48_seed[1] = (unsigned short) seed; - _rand48_seed[2] = (unsigned short) (seed > 16); + _rand48_seed[2] = (unsigned short) (seed >> 16); _rand48_mult[0] = RAND48_MULT_0; _rand48_mult[1] = RAND48_MULT_1; _rand48_mult[2] = RAND48_MULT_2; -- 2.40.0