From 08c824bbea992b823404d0cc99b0f4462d73085c Mon Sep 17 00:00:00 2001 From: Ilia Alshanetsky Date: Sun, 4 Dec 2005 17:31:40 +0000 Subject: [PATCH] MFB51: Fixed bug #35062 (socket_read() produces warnings on non blocking sockets). --- ext/sockets/sockets.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/ext/sockets/sockets.c b/ext/sockets/sockets.c index 9987856058..2b7085c18d 100644 --- a/ext/sockets/sockets.c +++ b/ext/sockets/sockets.c @@ -859,7 +859,19 @@ PHP_FUNCTION(socket_read) } if (retval == -1) { - PHP_SOCKET_ERROR(php_sock, "unable to read from socket", errno); + /* if the socket is in non-blocking mode and there's no data to read, + don't output any error, as this is a normal situation, and not an error */ + if (errno == EAGAIN +#ifdef EWOULDBLOCK + || errno == EWOULDBLOCK +#endif + ) { + php_sock->error = errno; + SOCKETS_G(last_error) = errno; + } else { + PHP_SOCKET_ERROR(php_sock, "unable to read from socket", errno); + } + efree(tmpbuf); RETURN_FALSE; } -- 2.50.1