From 07b412d4eed907c22ca8d28e609dafb8a5490d41 Mon Sep 17 00:00:00 2001 From: Mikhail Maltsev Date: Fri, 2 Mar 2018 10:03:02 +0000 Subject: [PATCH] [Sema] Improve test coverage of narrowing conversion diagnostics Summary: This patch adds tests of narrowing conversion diagnostics for the 'unscoped enum -> integer' case. Reviewers: faisalv, rsmith, rogfer01 Reviewed By: rogfer01 Subscribers: cfe-commits, rogfer01 Differential Revision: https://reviews.llvm.org/D43572 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@326551 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp b/test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp index 2142c098f8..4436cb0aac 100644 --- a/test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp +++ b/test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp @@ -147,8 +147,10 @@ void int_to_float() { void shrink_int() { // Not a constant expression. short s = 1; + UnscopedEnum e = EnumVal; unsigned short us = 1; Agg c1 = {s}; // expected-error {{ cannot be narrowed }} expected-note {{silence}} + Agg c2 = {e}; // expected-error {{ cannot be narrowed }} expected-note {{silence}} Agg s1 = {s}; // expected-error {{ cannot be narrowed }} expected-note {{silence}} Agg s2 = {us}; // expected-error {{ cannot be narrowed }} expected-note {{silence}} @@ -158,16 +160,19 @@ void shrink_int() { // long). long l1 = 1; Agg i1 = {l1}; // expected-error {{ cannot be narrowed }} expected-note {{silence}} + Agg i2 = {e}; // OK long long ll = 1; Agg l2 = {ll}; // OK // Constants. - Agg c2 = {127}; // OK - Agg c3 = {300}; // expected-error {{ cannot be narrowed }} expected-note {{silence}} expected-warning {{changes value}} - - Agg i2 = {0x7FFFFFFFU}; // OK - Agg i3 = {0x80000000U}; // expected-error {{ cannot be narrowed }} expected-note {{silence}} - Agg i4 = {-0x80000000L}; // expected-error {{ cannot be narrowed }} expected-note {{silence}} + Agg c3 = {127}; // OK + Agg c4 = {300}; // expected-error {{ cannot be narrowed }} expected-note {{silence}} expected-warning {{changes value}} + Agg c5 = {EnumVal}; // expected-error {{ cannot be narrowed }} expected-note {{silence}} expected-warning {{changes value}} + + Agg i3 = {0x7FFFFFFFU}; // OK + Agg i4 = {EnumVal}; // OK + Agg i5 = {0x80000000U}; // expected-error {{ cannot be narrowed }} expected-note {{silence}} + Agg i6 = {-0x80000000L}; // expected-error {{ cannot be narrowed }} expected-note {{silence}} // Bool is also an integer type, but conversions to it are a different AST // node. -- 2.40.0