From 074dda6d81315d3e1414ce018325c166bcb02028 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Wed, 4 Mar 2009 04:22:58 +0000 Subject: [PATCH] Comment fix: change a question to an answer. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@66010 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/CGDecl.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/CodeGen/CGDecl.cpp b/lib/CodeGen/CGDecl.cpp index 91071afeb8..3a4ef95350 100644 --- a/lib/CodeGen/CGDecl.cpp +++ b/lib/CodeGen/CGDecl.cpp @@ -127,11 +127,9 @@ void CodeGenFunction::EmitStaticBlockVarDecl(const VarDecl &D) { GenerateStaticCXXBlockVarDeclInit(D, GV); } else { // The initializer may differ in type from the global. Rewrite - // the global to match the initializer!? - // - // FIXME: This matches what we have been doing historically, but - // it seems bad. Shouldn't the init expression have the right - // type? + // the global to match the initializer. (We have to do this + // because some types, like unions, can't be completely represented + // in the LLVM type system.) if (GV->getType() != Init->getType()) { llvm::GlobalVariable *OldGV = GV; -- 2.40.0