From 070fec4a8362bfce136b8cd82a3977183b2394ee Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Wed, 18 Oct 2017 21:43:42 +0000 Subject: [PATCH] [Driver] Fix use after free in Hexagon toolchain code. No functionality change intended. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@316127 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Driver/ToolChains/Hexagon.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Driver/ToolChains/Hexagon.cpp b/lib/Driver/ToolChains/Hexagon.cpp index ea100fbcce..d4ab5dc5b7 100644 --- a/lib/Driver/ToolChains/Hexagon.cpp +++ b/lib/Driver/ToolChains/Hexagon.cpp @@ -28,8 +28,8 @@ using namespace clang; using namespace llvm::opt; // Default hvx-length for various versions. -static std::string getDefaultHvxLength(const StringRef &Cpu) { - return llvm::StringSwitch(Cpu) +static StringRef getDefaultHvxLength(StringRef Cpu) { + return llvm::StringSwitch(Cpu) .Case("v60", "64b") .Case("v62", "64b") .Default("128b"); @@ -93,7 +93,7 @@ static void handleHVXTargetFeatures(const Driver &D, const ArgList &Args, } // Default hvx-length based on Cpu. else if (HasHVX) - HVXLength = StringRef(getDefaultHvxLength(Cpu)); + HVXLength = getDefaultHvxLength(Cpu); if (!HVXLength.empty()) { HVXFeature = -- 2.50.1