From 06a8de0f0a1d317682271a97227be2f526c63364 Mon Sep 17 00:00:00 2001 From: Shane Carr Date: Mon, 11 Feb 2019 18:36:53 -0800 Subject: [PATCH] ICU-10923 Configure should fail when Python fails. --- icu4c/source/configure | 6 ++++++ icu4c/source/configure.ac | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/icu4c/source/configure b/icu4c/source/configure index 0853e07149a..91c3513743b 100755 --- a/icu4c/source/configure +++ b/icu4c/source/configure @@ -9134,12 +9134,18 @@ else --in_dir "$srcdir/data" \ --filter_file "$ICU_DATA_FILTER_FILE" \ > data/rules.mk + if test "$?" != "0"; then + as_fn_error $? "Python failed to run; see above error." "$LINENO" 5 + fi echo "Spawning Python to generate test/testdata/rules.mk..." PYTHONPATH="$srcdir/test/testdata:$srcdir/data" $PYTHON -m buildtool \ --mode gnumake \ --seqmode parallel \ --in_dir "$srcdir/test/testdata" \ > test/testdata/rules.mk + if test "$?" != "0"; then + as_fn_error $? "Python failed to run; see above error." "$LINENO" 5 + fi fi echo diff --git a/icu4c/source/configure.ac b/icu4c/source/configure.ac index 170e86909f9..e5feb4cde5b 100644 --- a/icu4c/source/configure.ac +++ b/icu4c/source/configure.ac @@ -1398,12 +1398,18 @@ else --in_dir "$srcdir/data" \ --filter_file "$ICU_DATA_FILTER_FILE" \ > data/rules.mk + if test "$?" != "0"; then + AC_MSG_ERROR(Python failed to run; see above error.) + fi echo "Spawning Python to generate test/testdata/rules.mk..." PYTHONPATH="$srcdir/test/testdata:$srcdir/data" $PYTHON -m buildtool \ --mode gnumake \ --seqmode parallel \ --in_dir "$srcdir/test/testdata" \ > test/testdata/rules.mk + if test "$?" != "0"; then + AC_MSG_ERROR(Python failed to run; see above error.) + fi fi echo -- 2.40.0