From 0670917b4ee5eec36697f8f66feccf61b08e730d Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Sat, 25 Mar 2017 10:12:36 +0100 Subject: [PATCH] rec: Use `cend()` instead of `end()` when comparing with a const iterator Reported by Coverity. --- pdns/pdns_recursor.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pdns/pdns_recursor.cc b/pdns/pdns_recursor.cc index 3a54b734a..a29a97186 100644 --- a/pdns/pdns_recursor.cc +++ b/pdns/pdns_recursor.cc @@ -3013,14 +3013,14 @@ try if(g_useOneSocketPerThread) { for (unsigned int threadId = 0; threadId < g_numWorkerThreads; threadId++) { - for(deferredAdd_t::const_iterator i = deferredAdds[threadId].begin(); i != deferredAdds[threadId].end(); ++i) { + for(deferredAdd_t::const_iterator i = deferredAdds[threadId].cbegin(); i != deferredAdds[threadId].cend(); ++i) { t_fdm->addReadFD(i->first, i->second); } } } else { if(!g_weDistributeQueries || !t_id) { // if we distribute queries, only t_id = 0 listens - for(deferredAdd_t::const_iterator i = deferredAdds[0].begin(); i != deferredAdds[0].end(); ++i) { + for(deferredAdd_t::const_iterator i = deferredAdds[0].cbegin(); i != deferredAdds[0].cend(); ++i) { t_fdm->addReadFD(i->first, i->second); } } -- 2.50.1