From 065a4055f796c545cdcc89a490be2d3288426d57 Mon Sep 17 00:00:00 2001 From: Anna Zaks Date: Mon, 29 Aug 2011 21:10:00 +0000 Subject: [PATCH] [analyzer] MacOSKeychainAPIChecker: Simplify getSymbolForRegion by using existing API. Thanks Jordy. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@138765 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../Checkers/MacOSKeychainAPIChecker.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp b/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp index 76d92874be..c2b547612c 100644 --- a/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp +++ b/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp @@ -198,14 +198,10 @@ unsigned MacOSKeychainAPIChecker::getTrackedFunctionIndex(StringRef Name, static SymbolRef getSymbolForRegion(CheckerContext &C, const MemRegion *R) { + // Implicit casts (ex: void* -> char*) can turn Symbolic region into element + // region, if that is the case, get the underlining region. + R = R->StripCasts(); if (!isa(R)) { - // Implicit casts (ex: void* -> char*) can turn Symbolic region into element - // region, if that is the case, get the underlining region. - if (const ElementRegion *ER = dyn_cast(R)) { - R = ER->getAsArrayOffset().getRegion(); - if (!R || !isa(R)) - return 0; - } else return 0; } return cast(R)->getSymbol(); -- 2.50.1