From 05e87fa41855c58de6435eb1c80a1bc6454362f7 Mon Sep 17 00:00:00 2001 From: Yasuo Ohgaki Date: Mon, 18 Jan 2016 12:03:41 +0900 Subject: [PATCH] Fixed bug #71070 Custom session handler write method returns false, warning message misleading This is commited to master only. If you have better error message suggestion, feel free to improve it. --- ext/session/session.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/ext/session/session.c b/ext/session/session.c index 8427f852bc..4385dca815 100644 --- a/ext/session/session.c +++ b/ext/session/session.c @@ -611,11 +611,16 @@ static void php_session_save_current_state(int write) /* {{{ */ } if ((ret == FAILURE) && !EG(exception)) { - php_error_docref(NULL, E_WARNING, "Failed to write session data (%s). Please " - "verify that the current setting of session.save_path " - "is correct (%s)", - PS(mod)->s_name, - PS(save_path)); + if (!PS(mod_user_implemented)) { + php_error_docref(NULL, E_WARNING, "Failed to write session data (%s). Please " + "verify that the current setting of session.save_path " + "is correct (%s)", + PS(mod)->s_name, + PS(save_path)); + } else { + php_error_docref(NULL, E_WARNING, "Failed to write session data using user " + "defined save handler. (session.save_path: %s)", PS(save_path)); + } } } } -- 2.50.1