From 052e0151ca6f3fdd395add594421776852aaefc0 Mon Sep 17 00:00:00 2001 From: Christophe Jaillet Date: Sat, 10 Aug 2019 08:59:13 +0000 Subject: [PATCH] Fix a signed/unsigned comparison that can never match. (+ add a missing space to improve formating) Spotted by gcc 9.1 and -Wextra git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1864865 13f79535-47bb-0310-9956-ffa450edef68 --- server/protocol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/protocol.c b/server/protocol.c index 4c79ae165a..7a97b0d98e 100644 --- a/server/protocol.c +++ b/server/protocol.c @@ -2145,7 +2145,7 @@ static int r_flush(apr_vformatter_buff_t *buff) AP_DECLARE(int) ap_vrprintf(request_rec *r, const char *fmt, va_list va) { - apr_size_t written; + int written; struct ap_vrprintf_data vd; char vrprintf_buf[AP_IOBUFSIZE]; @@ -2163,7 +2163,7 @@ AP_DECLARE(int) ap_vrprintf(request_rec *r, const char *fmt, va_list va) int n = vd.vbuff.curpos - vrprintf_buf; /* last call to buffer_output, to finish clearing the buffer */ - if (buffer_output(r, vrprintf_buf,n) != APR_SUCCESS) + if (buffer_output(r, vrprintf_buf, n) != APR_SUCCESS) return -1; written += n; -- 2.40.0