From 0477bf3a934b9e959ce4a64f25ce24310797d50e Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Mon, 22 Mar 2010 12:11:44 +0000 Subject: [PATCH] Fix a crash in _elementtree related to lone unicode surrogates. Fix a segfault on: >>> import _elementtree >>> _elementtree.iterparse('/bin/sh', ("\uDC80", "\ud808\udf45")) --- Modules/_elementtree.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Modules/_elementtree.c b/Modules/_elementtree.c index 88374cc352..2fad8e2f47 100644 --- a/Modules/_elementtree.c +++ b/Modules/_elementtree.c @@ -2734,6 +2734,8 @@ xmlparser_setevents(XMLParserObject* self, PyObject* args) char* event; if (PyUnicode_Check(item)) { event = _PyUnicode_AsString(item); + if (event == NULL) + goto error; } else if (PyBytes_Check(item)) event = PyBytes_AS_STRING(item); else { -- 2.50.1