From 040de5747718c1608d13f9f2ba99b5fabeb0e331 Mon Sep 17 00:00:00 2001 From: "Dmitry V. Levin" Date: Thu, 16 Jul 2015 21:46:05 +0000 Subject: [PATCH] sysmips.c: cleanup * sysmips.c [MIPS] (sys_sysmips): Use switch statement. Use printaddr. Fix misprinted ", " delimiter. --- sysmips.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/sysmips.c b/sysmips.c index 36ee9b9d..a47facf9 100644 --- a/sysmips.c +++ b/sysmips.c @@ -18,26 +18,32 @@ SYS_FUNC(sysmips) { printxval(sysmips_operations, tcp->u_arg[0], "???"); - if (!verbose(tcp)) { - tprintf("%ld, %ld, %ld", tcp->u_arg[1], tcp->u_arg[2], tcp->u_arg[3]); - } else if (tcp->u_arg[0] == SETNAME) { + tprints(", "); + + switch (tcp->u_arg[0]) { + case SETNAME: { char nodename[__NEW_UTS_LEN + 1]; - tprints(", "); + + if (!verbose(tcp)) + break; if (umovestr(tcp, tcp->u_arg[1], (__NEW_UTS_LEN + 1), nodename) < 0) { - tprintf("%#lx", tcp->u_arg[1]); + printaddr(tcp->u_arg[1]); } else { print_quoted_string(nodename, __NEW_UTS_LEN + 1, QUOTE_0_TERMINATED); } - } else if (tcp->u_arg[0] == MIPS_ATOMIC_SET) { - tprintf(", %#lx, 0x%lx", tcp->u_arg[1], tcp->u_arg[2]); - } else if (tcp->u_arg[0] == MIPS_FIXADE) { - tprintf(", 0x%lx", tcp->u_arg[1]); - } else { - tprintf("%ld, %ld, %ld", tcp->u_arg[1], tcp->u_arg[2], tcp->u_arg[3]); + return RVAL_DECODED; + } + case MIPS_ATOMIC_SET: + tprintf("%#lx, 0x%lx", tcp->u_arg[1], tcp->u_arg[2]); + return RVAL_DECODED; + case MIPS_FIXADE: + tprintf("0x%lx", tcp->u_arg[1]); + return RVAL_DECODED; } + tprintf("%ld, %ld, %ld", tcp->u_arg[1], tcp->u_arg[2], tcp->u_arg[3]); return RVAL_DECODED; } -- 2.40.0