From 03dc0681a4b2cc87374d25a8168d18ce4197ea80 Mon Sep 17 00:00:00 2001 From: Thomas Lively Date: Mon, 28 Jan 2019 23:44:31 +0000 Subject: [PATCH] [WebAssembly] Expand BUILD_PAIR nodes Reviewers: aheejin Subscribers: dschuff, sbc100, jgravelle-google, hiraditya, sunfish Differential Revision: https://reviews.llvm.org/D57276 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@352442 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../WebAssembly/WebAssemblyISelLowering.cpp | 3 ++ test/CodeGen/WebAssembly/simd-build-pair.ll | 33 +++++++++++++++++++ 2 files changed, 36 insertions(+) create mode 100644 test/CodeGen/WebAssembly/simd-build-pair.ll diff --git a/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp b/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp index 7186d29d7b4..1a8b598c074 100644 --- a/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp +++ b/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp @@ -225,6 +225,9 @@ WebAssemblyTargetLowering::WebAssemblyTargetLowering( } } + // Don't do anything clever with build_pairs + setOperationAction(ISD::BUILD_PAIR, MVT::i64, Expand); + // Trap lowers to wasm unreachable setOperationAction(ISD::TRAP, MVT::Other, Legal); diff --git a/test/CodeGen/WebAssembly/simd-build-pair.ll b/test/CodeGen/WebAssembly/simd-build-pair.ll new file mode 100644 index 00000000000..a3b7ab8e8ec --- /dev/null +++ b/test/CodeGen/WebAssembly/simd-build-pair.ll @@ -0,0 +1,33 @@ +; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -mattr=simd128 | FileCheck %s --check-prefixes CHECK + +target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128" +target triple = "wasm32-unknown-unknown" + +; Test that BUILD_PAIR dag nodes are correctly lowered. +; This code produces a selection DAG like the following: + +; t0: ch = EntryToken +; t3: v4i32,ch = load<(load 16 from `<4 x i32>* undef`)> t0, undef:i32, undef:i32 +; t30: i32 = extract_vector_elt t3, Constant:i32<2> +; t28: i32 = extract_vector_elt t3, Constant:i32<3> +; t24: i64 = build_pair t30, t28 +; t8: ch = store<(store 8 into `i64* undef`, align 1)> t3:1, t24, undef:i32, undef:i32 +; t9: ch = WebAssemblyISD::RETURN t8 + +; CHECK: i32x4.extract_lane +; CHECK-NEXT: i64.extend_i32_u +; CHECK-NEXT: i32x4.extract_lane +; CHECK-NEXT: i64.extend_i32_u +; CHECK-NEXT: i64.const {{.*}} 32 +; CHECK-NEXT: i64.shl +; CHECK-NEXT: i64.or +; CHECK-NEXT: i64.store +define void @build_pair_i32s() { +entry: + %0 = load <4 x i32>, <4 x i32>* undef, align 16 + %shuffle.i184 = shufflevector <4 x i32> %0, <4 x i32> undef, <4 x i32> + %bc357 = bitcast <4 x i32> %shuffle.i184 to <2 x i64> + %1 = extractelement <2 x i64> %bc357, i32 0 + store i64 %1, i64* undef, align 1 + ret void +} -- 2.50.1