From 02313bb3a40b87500edd10b89f49e1f582733ea3 Mon Sep 17 00:00:00 2001 From: "William A. Rowe Jr" Date: Thu, 17 Jan 2019 17:19:04 +0000 Subject: [PATCH] Clarify potentially unsuccessful success results. Curious why modules/aaa/mod_authz_dbm.c:get_dbm_grp() doesn't need the same net changes? git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1851552 13f79535-47bb-0310-9956-ffa450edef68 --- modules/aaa/mod_authn_dbm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/modules/aaa/mod_authn_dbm.c b/modules/aaa/mod_authn_dbm.c index 46fe6ffc80..e54058563b 100644 --- a/modules/aaa/mod_authn_dbm.c +++ b/modules/aaa/mod_authn_dbm.c @@ -101,6 +101,10 @@ static apr_status_t fetch_dbm_value(const char *dbmtype, const char *dbmfile, apr_dbm_close(f); + /* NOT FOUND is not an error case; this is indicated by a NULL result. + * Treat all NULL lookup/error results as success for the simple case + * of auth credential lookup, these are DECLINED in both cases. + */ return APR_SUCCESS; } -- 2.50.1