From 0153c4c4663f87164434ae418a735900f598c7e1 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 15 Jan 2008 22:18:20 +0000 Subject: [PATCH] Be less wishy-washy in the documentation and comments about whether a ParameterStatus message can be sent during COPY OUT: it's definitely possible, since COPY from a SELECT subquery can trigger any user-defined function. --- doc/src/sgml/protocol.sgml | 10 +++++----- src/interfaces/libpq/fe-protocol3.c | 7 +++---- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml index d32f26fb7b..f9dfb1f45d 100644 --- a/doc/src/sgml/protocol.sgml +++ b/doc/src/sgml/protocol.sgml @@ -1,4 +1,4 @@ - + Frontend/Backend Protocol @@ -1044,10 +1044,10 @@ - It is possible for NoticeResponse messages to be interspersed between - CopyData messages; frontends must handle this case, and should be - prepared for other asynchronous message types as well (see ). Otherwise, any message type other than + It is possible for NoticeResponse and ParameterStatus messages to be + interspersed between CopyData messages; frontends must handle these cases, + and should be prepared for other asynchronous message types as well (see + ). Otherwise, any message type other than CopyData or CopyDone may be treated as terminating copy-out mode. diff --git a/src/interfaces/libpq/fe-protocol3.c b/src/interfaces/libpq/fe-protocol3.c index 2f57500e4f..c40868805f 100644 --- a/src/interfaces/libpq/fe-protocol3.c +++ b/src/interfaces/libpq/fe-protocol3.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/interfaces/libpq/fe-protocol3.c,v 1.32 2008/01/14 18:46:17 tgl Exp $ + * $PostgreSQL: pgsql/src/interfaces/libpq/fe-protocol3.c,v 1.33 2008/01/15 22:18:20 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -1310,9 +1310,8 @@ getCopyDataMessage(PGconn *conn) /* * If it's a legitimate async message type, process it. (NOTIFY * messages are not currently possible here, but we handle them for - * completeness. NOTICE is definitely possible, and ParameterStatus - * could probably be made to happen.) Otherwise, if it's anything - * except Copy Data, report end-of-copy. + * completeness.) Otherwise, if it's anything except Copy Data, + * report end-of-copy. */ switch (id) { -- 2.40.0