From 014ca3a53cb24d8e12e87f43a880efc52940a8be Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Fri, 2 Sep 2011 16:19:30 +0200 Subject: [PATCH] Trivial fixes on error paths * strace.c (startup_attach): Emit message on fork() failure. (startup_child): Remove non-informative comment. * util.c (ptrace_restart): use perror_msg() on error instead of fprintf(). Signed-off-by: Denys Vlasenko --- strace.c | 4 ++-- util.c | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/strace.c b/strace.c index fcdae0bb..722a0f0b 100644 --- a/strace.c +++ b/strace.c @@ -424,7 +424,7 @@ startup_attach(void) if (daemonized_tracer) { pid_t pid = fork(); if (pid < 0) { - _exit(1); + perror_msg_and_die("fork"); } if (pid) { /* parent */ /* @@ -641,7 +641,7 @@ startup_child(char **argv) # ifndef FREEBSD pause(); # else - kill(pid, SIGSTOP); /* stop HERE */ + kill(pid, SIGSTOP); # endif #else /* !USE_PROCFS */ if (!daemonized_tracer) { diff --git a/util.c b/util.c index 20311fce..0658bc0a 100644 --- a/util.c +++ b/util.c @@ -224,8 +224,7 @@ ptrace_restart(int op, struct tcb *tcp, int sig) msg = "CONT"; if (op == PTRACE_DETACH) msg = "DETACH"; - fprintf(stderr, "strace: ptrace(PTRACE_%s,1,%d): %s\n", - msg, sig, strerror(err)); + perror_msg("ptrace(PTRACE_%s,1,%d)", msg, sig); return -1; } -- 2.40.0