From 010d9e5d16e1ab648d61143e9b813cda45962b55 Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Sat, 4 Sep 2021 09:50:03 -0700 Subject: [PATCH] make final Pylint step fail for any non-FIXME warning/error The gating Pylint check now fails if any warning or error is detected, excluding FIXME comments. This should hopefully lead to improved code quality in Python introduced into the code base in future. --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index f4596a104..2f50a4958 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1141,7 +1141,7 @@ lint_pylint: - echo "$CI_JOB_NAME-warnings `egrep -c '\<[CRWEF][[:digit:]]{4}\>' $logfile`" > metrics.txt - rm $logfile - cat metrics.txt - - python3 -m pylint --errors-only --rcfile=.pylintrc `find . -name '*.py' | xargs` + - python3 -m pylint --rcfile=.pylintrc --disable=fixme `find . -name '*.py' | xargs` artifacts: when: on_success expire_in: 1 week -- 2.40.0