]> granicus.if.org Git - postgresql/commit
Use slots in trigger infrastructure, except for the actual invocation.
authorAndres Freund <andres@anarazel.de>
Wed, 27 Feb 2019 04:30:28 +0000 (20:30 -0800)
committerAndres Freund <andres@anarazel.de>
Wed, 27 Feb 2019 04:31:38 +0000 (20:31 -0800)
commitff11e7f4b9ae017585c3ba146db7ba39c31f209a
tree37828b8d2ab7bda386b276129b456793c7ac908b
parentb8d71745eac0a12740a70dc78cbcdedadade37f8
Use slots in trigger infrastructure, except for the actual invocation.

In preparation for abstracting table storage, convert trigger.c to
track tuples in slots. Which also happens to make code calling
triggers simpler.

As the calling interface for triggers themselves is not changed in
this patch, HeapTuples still are extracted from the slot at that
time. But that's handled solely inside trigger.c, not visible to
callers. It's quite likely that we'll want to revise the external
trigger interface, but that's a separate large project.

As part of this work the slots used for old/new/return tuples are
moved from EState into ResultRelInfo, as different updated tables
might need different slots. The slots are now also now created
on-demand, which is good both from an efficiency POV, but also makes
the modifying code simpler.

Author: Andres Freund, Amit Khandekar and Ashutosh Bapat
Discussion: https://postgr.es/m/20180703070645.wchpu5muyto5n647@alap3.anarazel.de
14 files changed:
contrib/postgres_fdw/postgres_fdw.c
src/backend/commands/copy.c
src/backend/commands/tablecmds.c
src/backend/commands/trigger.c
src/backend/executor/execMain.c
src/backend/executor/execReplication.c
src/backend/executor/execTuples.c
src/backend/executor/execUtils.c
src/backend/executor/nodeModifyTable.c
src/backend/replication/logical/worker.c
src/backend/utils/adt/ri_triggers.c
src/include/commands/trigger.h
src/include/executor/executor.h
src/include/nodes/execnodes.h