Implement %m in src/port/snprintf.c, and teach elog.c to rely on that.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 26 Sep 2018 17:31:56 +0000 (13:31 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 26 Sep 2018 17:31:56 +0000 (13:31 -0400)
commitd6c55de1f99a9028540516316b95321a7b12a540
tree7c95ff050f56bcf20648e3d7a8a7fbb2ddbc7293
parent96bf88d52711ad3a0a4cc2d1d9cb0e2acab85e63
Implement %m in src/port/snprintf.c, and teach elog.c to rely on that.

I started out with the idea that we needed to detect use of %m format specs
in contexts other than elog/ereport calls, because we couldn't rely on that
working in *printf calls.  But a better answer is to fix things so that it
does work.  Now that we're using snprintf.c all the time, we can implement
%m in that and we've fixed the problem.

This requires also adjusting our various printf-wrapping functions so that
they ensure "errno" is preserved when they call snprintf.c.

Remove elog.c's handmade implementation of %m, and let it rely on
snprintf to support the feature.  That should provide some performance
gain, though I've not attempted to measure it.

There are a lot of places where we could now simplify 'printf("%s",
strerror(errno))' into 'printf("%m")', but I'm not in any big hurry
to make that happen.

Patch by me, reviewed by Michael Paquier

Discussion: https://postgr.es/m/2975.1526862605@sss.pgh.pa.us
src/backend/lib/stringinfo.c
src/backend/utils/error/elog.c
src/bin/pg_dump/pg_backup_archiver.c
src/bin/pg_dump/pg_backup_tar.c
src/common/psprintf.c
src/interfaces/libpq/pqexpbuffer.c
src/pl/plpython/plpy_elog.c
src/port/snprintf.c