]> granicus.if.org Git - postgresql/commit
Consistently declare timestamp variables as TimestampTz.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 23 Feb 2017 20:57:08 +0000 (15:57 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 23 Feb 2017 20:57:08 +0000 (15:57 -0500)
commitc29aff959dc64f7321062e7f33d8c6ec23db53d3
tree4c3efa167e01805b2e4fcd6eead2e1a320a2c420
parentb9d092c962ea3262930e3c31a8c3d79b66ce9d43
Consistently declare timestamp variables as TimestampTz.

Twiddle the replication-related code so that its timestamp variables
are declared TimestampTz, rather than the uninformative "int64" that
was previously used for meant-to-be-always-integer timestamps.
This resolves the int64-vs-TimestampTz declaration inconsistencies
introduced by commit 7c030783a, though in the opposite direction to
what was originally suggested.

This required including datatype/timestamp.h in a couple more places
than before.  I decided it would be a good idea to slim down that
header by not having it pull in <float.h> etc, as those headers are
no longer at all relevant to its purpose.  Unsurprisingly, a small number
of .c files turn out to have been depending on those inclusions, so add
them back in the .c files as needed.

Discussion: https://postgr.es/m/26788.1487455319@sss.pgh.pa.us
Discussion: https://postgr.es/m/27694.1487456324@sss.pgh.pa.us
22 files changed:
contrib/auth_delay/auth_delay.c
contrib/btree_gist/btree_ts.c
src/backend/access/common/reloptions.c
src/backend/access/transam/xlog.c
src/backend/commands/prepare.c
src/backend/executor/nodeBitmapHeapscan.c
src/backend/replication/basebackup.c
src/backend/replication/logical/worker.c
src/backend/replication/walreceiver.c
src/backend/replication/walsender.c
src/backend/tcop/pquery.c
src/backend/utils/adt/nabstime.c
src/backend/utils/cache/inval.c
src/backend/utils/time/snapmgr.c
src/bin/pg_basebackup/pg_recvlogical.c
src/bin/pg_basebackup/receivelog.c
src/bin/pg_basebackup/streamutil.c
src/bin/pg_basebackup/streamutil.h
src/include/datatype/timestamp.h
src/include/utils/snapmgr.h
src/include/utils/snapshot.h
src/include/utils/timestamp.h