]> granicus.if.org Git - postgresql/commit
Fix reporting of violations in ExecConstraints, again.
authorRobert Haas <rhaas@postgresql.org>
Mon, 10 Apr 2017 16:20:08 +0000 (12:20 -0400)
committerRobert Haas <rhaas@postgresql.org>
Mon, 10 Apr 2017 16:20:08 +0000 (12:20 -0400)
commitc0a8ae7be392aa09dd7e148ff662013e8e148893
treec2c280cf4d22b8f4a056247fbce70db8d14f224b
parent244f1c89070c1a661623bf1eaddf1307f8f598a3
Fix reporting of violations in ExecConstraints, again.

We decided in f1b4c771ea74f42447dccaed42ffcdcccf3aa694 to pass the
original slot to ExecConstraints(), but that breaks when there are
BEFORE ROW triggers involved.  So we need to do reverse-map the tuples
back to the original descriptor instead, as Amit originally proposed.

Amit Langote, reviewed by Ashutosh Bapat.  One overlooked comment
fixed by me.

Discussion: http://postgr.es/m/b3a17254-6849-e542-2353-bde4e880b6a4@lab.ntt.co.jp
src/backend/commands/copy.c
src/backend/executor/execMain.c
src/backend/executor/execReplication.c
src/backend/executor/nodeModifyTable.c
src/include/executor/executor.h
src/test/regress/expected/insert.out
src/test/regress/sql/insert.sql