]> granicus.if.org Git - python/commit
bpo-31672: Fix string.Template accidentally matched non-ASCII identifiers (GH-3872)
authorINADA Naoki <methane@users.noreply.github.com>
Fri, 13 Oct 2017 07:02:23 +0000 (16:02 +0900)
committerGitHub <noreply@github.com>
Fri, 13 Oct 2017 07:02:23 +0000 (16:02 +0900)
commitb22273ec5d1992b0cbe078b887427ae9977dfb78
tree513406f0548f326404ff00e67f6a7e9093c78dd2
parent925510449984399cf58711843ddfe2e8007c3878
bpo-31672: Fix string.Template accidentally matched non-ASCII identifiers (GH-3872)

Pattern `[a-z]` with `IGNORECASE` flag can match to some non-ASCII characters.

Straightforward solution for this is using `IGNORECASE | ASCII` flag.
But users may subclass `Template` and override only `idpattern`. So we want to
avoid changing `Template.flags`.

So this commit uses local flag `-i` for `idpattern` and change `[a-z]` to `[a-zA-Z]`.
Doc/library/string.rst
Lib/string.py
Lib/test/test_string.py
Misc/NEWS.d/next/Library/2017-10-12-02-47-16.bpo-31672.DaOkVd.rst [new file with mode: 0644]