]> granicus.if.org Git - php/commit
Change Big Endian backup implementations to use signed indexes
authorSara Golemon <pollita@php.net>
Wed, 12 Oct 2016 03:43:02 +0000 (20:43 -0700)
committerSara Golemon <pollita@php.net>
Wed, 12 Oct 2016 03:43:02 +0000 (20:43 -0700)
commitb041bebb88db17a5fbd72c40047aaca944f9e392
tree8ca0388417e189388d52127763afc3fda449cf0a
parent6ddfce116b55ec1add4b6dd05006a979bb9b873a
Change Big Endian backup implementations to use signed indexes

load64() counted down from 7..0, but the decrement turned 0 into 255.
This means the loop would never terminate on Big Endian systems.

Just use signed char integers since we're only dealing with values from 0..7 anyway.

Closes https://bugs.php.net/bug.php?id=73282
ext/hash/hash_sha3.c