]> granicus.if.org Git - python/commit
closes bpo-34056: Always return bytes from _HackedGetData.get_data(). (GH-8130)
authorBenjamin Peterson <benjamin@python.org>
Sat, 7 Jul 2018 03:41:06 +0000 (20:41 -0700)
committerGitHub <noreply@github.com>
Sat, 7 Jul 2018 03:41:06 +0000 (20:41 -0700)
commitb0274f2cddd36b49fe5080efbe160277ef546471
tree6a13b9a5c333d79953a0d14af161c9b278c3b78c
parente25399b40cd15620e77c9ad2ed24549006ae9b47
closes bpo-34056: Always return bytes from _HackedGetData.get_data(). (GH-8130)

* Always return bytes from _HackedGetData.get_data().

Ensure the imp.load_source shim always returns bytes by reopening the file in
binary mode if needed. Hash-based pycs have to receive the source code in bytes.

It's tempting to change imp.get_suffixes() to always return 'rb' as a mode, but
that breaks some stdlib tests and likely 3rdparty code, too.
Lib/imp.py
Lib/test/test_imp.py
Misc/NEWS.d/next/Library/2018-07-05-22-45-46.bpo-34056.86isrU.rst [new file with mode: 0644]