]> granicus.if.org Git - postgresql/commit
Handle heap rewrites better in logical replication
authorPeter Eisentraut <peter_e@gmx.net>
Tue, 26 Sep 2017 14:03:56 +0000 (10:03 -0400)
committerPeter Eisentraut <peter_e@gmx.net>
Tue, 26 Sep 2017 14:13:43 +0000 (10:13 -0400)
commitab28feae2bd3d4629bd73ae3548e671c57d785f0
treed9253da0d2621abc4522bafcdbf67ea37cce4ca4
parent22c5e73562c53437979efec4c26cd9fff408777c
Handle heap rewrites better in logical replication

A FOR ALL TABLES publication naturally considers all base tables to be a
candidate for replication.  This includes transient heaps that are
created during a table rewrite during DDL.  This causes failures on the
subscriber side because it will not have a table like pg_temp_16386 to
receive data (and if it did, it would be the wrong table).

The prevent this problem, we filter out any tables that match this
naming pattern and match an actual table from FOR ALL TABLES
publications.  This is only a heuristic, meaning that user tables that
match that naming could accidentally be omitted.  A more robust solution
might require an explicit marking of such tables in pg_class somehow.

Reported-by: yxq <yxq@o2.pl>
Bug: #14785
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Petr Jelinek <petr.jelinek@2ndquadrant.com>
src/backend/replication/pgoutput/pgoutput.c
src/test/subscription/t/006_rewrite.pl [new file with mode: 0644]