]> granicus.if.org Git - postgresql/commit
Remove useless duplicate inclusions of system header files.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 25 Feb 2017 21:12:24 +0000 (16:12 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 25 Feb 2017 21:12:55 +0000 (16:12 -0500)
commit9e3755ecb2d058f7d123dd35a2e1784006190962
treef938cae7833ef756947d4ac074a83d31f5f6113d
parent5639ceddcb7f3efa8751b2ba6e50cc1d27cc2a45
Remove useless duplicate inclusions of system header files.

c.h #includes a number of core libc header files, such as <stdio.h>.
There's no point in re-including these after having read postgres.h,
postgres_fe.h, or c.h; so remove code that did so.

While at it, also fix some places that were ignoring our standard pattern
of "include postgres[_fe].h, then system header files, then other Postgres
header files".  While there's not any great magic in doing it that way
rather than system headers last, it's silly to have just a few files
deviating from the general pattern.  (But I didn't attempt to enforce this
globally, only in files I was touching anyway.)

I'd be the first to say that this is mostly compulsive neatnik-ism,
but over time it might save enough compile cycles to be useful.
77 files changed:
contrib/fuzzystrmatch/dmetaphone.c
contrib/ltree/crc32.c
contrib/pgcrypto/px.h
src/backend/access/transam/timeline.c
src/backend/access/transam/twophase.c
src/backend/access/transam/xlogarchive.c
src/backend/commands/dbcommands.c
src/backend/commands/tablespace.c
src/backend/libpq/ifaddr.c
src/backend/port/atomics.c
src/backend/port/dynloader/freebsd.h
src/backend/port/dynloader/netbsd.h
src/backend/port/dynloader/openbsd.h
src/backend/port/win32/crashdump.c
src/backend/postmaster/autovacuum.c
src/backend/replication/basebackup.c
src/backend/replication/logical/snapbuild.c
src/backend/replication/walreceiverfuncs.c
src/backend/storage/ipc/dsm.c
src/backend/storage/ipc/dsm_impl.c
src/backend/storage/ipc/latch.c
src/backend/utils/adt/cash.c
src/backend/utils/adt/dbsize.c
src/backend/utils/adt/inet_cidr_ntop.c
src/backend/utils/adt/inet_net_pton.c
src/backend/utils/adt/pg_locale.c
src/backend/utils/init/miscinit.c
src/bin/initdb/initdb.c
src/bin/pg_basebackup/pg_basebackup.c
src/bin/pg_basebackup/pg_receivewal.c
src/bin/pg_basebackup/streamutil.c
src/bin/pg_ctl/pg_ctl.c
src/bin/pg_dump/parallel.c
src/bin/pg_dump/pg_backup_archiver.c
src/bin/pg_dump/pg_dump.c
src/bin/pg_dump/pg_dumpall.c
src/bin/pg_dump/pg_restore.c
src/bin/pg_resetwal/pg_resetwal.c
src/bin/pg_rewind/copy_fetch.c
src/bin/pg_rewind/fetch.c
src/bin/pg_rewind/file_ops.c
src/bin/pg_rewind/filemap.c
src/bin/pg_rewind/libpq_fetch.c
src/bin/pg_upgrade/dump.c
src/bin/pg_upgrade/exec.c
src/bin/pg_upgrade/option.c
src/bin/pg_upgrade/parallel.c
src/bin/pg_upgrade/tablespace.c
src/bin/pgevent/pgevent.c
src/bin/psql/command.c
src/bin/psql/crosstabview.c
src/bin/psql/help.c
src/bin/psql/startup.c
src/common/ip.c
src/common/username.c
src/common/wait_error.c
src/fe_utils/print.c
src/include/libpq/libpq.h
src/include/port/atomics/generic-msvc.h
src/include/utils/pg_locale.h
src/interfaces/ecpg/ecpglib/data.c
src/interfaces/ecpg/ecpglib/execute.c
src/interfaces/ecpg/ecpglib/typename.c
src/interfaces/ecpg/preproc/ecpg.c
src/interfaces/ecpg/preproc/pgc.l
src/interfaces/libpq/fe-connect.c
src/interfaces/libpq/libpq-int.h
src/interfaces/libpq/pthread-win32.c
src/pl/plperl/plperl.c
src/port/chklocale.c
src/port/dirmod.c
src/port/inet_net_ntop.c
src/port/open.c
src/port/system.c
src/test/isolation/isolationtester.c
src/timezone/strftime.c
src/timezone/zic.c