]> granicus.if.org Git - postgresql/commit
Unpack jbvBinary objects passed to pushJsonbValue
authorAndrew Dunstan <andrew@dunslane.net>
Fri, 22 May 2015 14:21:41 +0000 (10:21 -0400)
committerAndrew Dunstan <andrew@dunslane.net>
Fri, 22 May 2015 14:31:29 +0000 (10:31 -0400)
commit9b74f32cdbff8b9be47fc69164eae552050509ff
tree3713185bffdec59fa97fb498c737448a76c1149e
parent7d0d2b8da1fee13e473495ffdfc7d642b37ebd63
Unpack jbvBinary objects passed to pushJsonbValue

pushJsonbValue was accepting jbvBinary objects passed as WJB_ELEM or
WJB_VALUE data. While this succeeded, when those objects were later
encountered in attempting to convert the result to Jsonb, errors
occurred. With this change we ghuarantee that a JSonbValue constructed
from calls to pushJsonbValue does not contain any jbvBinary objects.
This cures a problem observed with jsonb_delete.

This means callers of pushJsonbValue no longer need to perform this
unpacking themselves. A subsequent patch will perform some cleanup in
that area.

The error was not triggered by any 9.4 code, but this is a publicly
visible routine, and so the error could be exercised by third party
code, therefore backpatch to 9.4.

Bug report from Peter Geoghegan, fix by me.
src/backend/utils/adt/jsonb_util.c
src/include/utils/jsonb.h