]> granicus.if.org Git - postgresql/commit
Detect unused steps in isolation specs and do some cleanup
authorMichael Paquier <michael@paquier.xyz>
Sat, 24 Aug 2019 02:45:05 +0000 (11:45 +0900)
committerMichael Paquier <michael@paquier.xyz>
Sat, 24 Aug 2019 02:45:05 +0000 (11:45 +0900)
commit989d23b04beac0c26f44c379b04ac781eaa4265e
tree73adaa8e3a9c4a9a5b0f744c6f1e29e7cc4d73c1
parent9903338b5ea59093d77cfe50ec0b1c22d4a7d843
Detect unused steps in isolation specs and do some cleanup

This is useful for developers to find out if an isolation spec is
over-engineered or if it needs more work by warning at the end of a
test run if a step is not used, generating a failure with extra diffs.

While on it, clean up all the specs which include steps not used in any
permutations to simplify them.

Author: Michael Paquier
Reviewed-by: Asim Praveen, Melanie Plageman
Discussion: https://postgr.es/m/20190819080820.GG18166@paquier.xyz
src/test/isolation/isolationtester.c
src/test/isolation/isolationtester.h
src/test/isolation/specparse.y
src/test/isolation/specs/freeze-the-dead.spec
src/test/isolation/specs/insert-conflict-do-nothing.spec
src/test/isolation/specs/insert-conflict-do-update-2.spec
src/test/isolation/specs/insert-conflict-do-update.spec
src/test/isolation/specs/sequence-ddl.spec
src/test/isolation/specs/tuplelock-upgrade-no-deadlock.spec