]> granicus.if.org Git - postgresql/commit
Assume wcstombs(), towlower(), and sibling functions are always present.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 22 Sep 2017 15:00:58 +0000 (11:00 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 22 Sep 2017 15:00:58 +0000 (11:00 -0400)
commit85feb77aa09cda9ff3e12cf95c757c499dc25343
tree313b8bb0eb9cf4cff63a92dd5345d9d5c51b3b3a
parente6023ee7fa73a2d9a2d7524f63584844b2291def
Assume wcstombs(), towlower(), and sibling functions are always present.

These functions are required by SUS v2, which is our minimum baseline
for Unix platforms, and are present on all interesting Windows versions
as well.  Even our oldest buildfarm members have them.  Thus, we were not
testing the "!USE_WIDE_UPPER_LOWER" code paths, which explains why the bug
fixed in commit e6023ee7f escaped detection.  Per discussion, there seems
to be no more real-world value in maintaining this option.  Hence, remove
the configure-time tests for wcstombs() and towlower(), remove the
USE_WIDE_UPPER_LOWER symbol, and remove all the !USE_WIDE_UPPER_LOWER code.
There's not actually all that much of the latter, but simplifying the #if
nests is a win in itself.

Discussion: https://postgr.es/m/20170921052928.GA188913@rfd.leadboat.com
13 files changed:
configure
configure.in
src/backend/regex/regc_pg_locale.c
src/backend/tsearch/regis.c
src/backend/tsearch/ts_locale.c
src/backend/tsearch/wparser_def.c
src/backend/utils/adt/formatting.c
src/backend/utils/adt/pg_locale.c
src/include/c.h
src/include/pg_config.h.in
src/include/pg_config.h.win32
src/include/tsearch/ts_locale.h
src/include/utils/pg_locale.h