]> granicus.if.org Git - postgresql/commit
Expression evaluation based aggregate transition invocation.
authorAndres Freund <andres@anarazel.de>
Tue, 9 Jan 2018 21:25:38 +0000 (13:25 -0800)
committerAndres Freund <andres@anarazel.de>
Tue, 9 Jan 2018 21:25:38 +0000 (13:25 -0800)
commit69c3936a1499b772a749ae629fc59b2d72722332
treec09720cc2d9f8ea9dda6b6bb1ea3b0d256a9b6b4
parent272c2ab9fd0a604e3200030b1ea26fd464c44935
Expression evaluation based aggregate transition invocation.

Previously aggregate transition and combination functions were invoked
by special case code in nodeAgg.c, evaluating input and filters
separately using the expression evaluation machinery. That turns out
to not be great for performance for several reasons:

- repeated expression evaluations have some cost
- the transition functions invocations are poorly predicted, as
  commonly there are multiple aggregates in a query, resulting in the
  same call-stack invoking different functions.
- filter and input computation had to be done separately
- the special case code made it hard to implement JITing of the whole
  transition function invocation

Address this by building one large expression that computes input,
evaluates filters, and invokes transition functions.

This leads to moderate speedups in queries bottlenecked by aggregate
computations, and enables large speedups for similar cases once JITing
is done.

There's potential for further improvement:
- It'd be nice if we could simplify the somewhat expensive
  aggstate->all_pergroups lookups.
- right now there's still an advance_transition_function invocation in
  nodeAgg.c, leading to some code duplication.

Author: Andres Freund
Discussion: https://postgr.es/m/20170901064131.tazjxwus3k2w3ybh@alap3.anarazel.de
src/backend/executor/execExpr.c
src/backend/executor/execExprInterp.c
src/backend/executor/nodeAgg.c
src/include/executor/execExpr.h
src/include/executor/executor.h
src/include/executor/nodeAgg.h
src/include/nodes/execnodes.h
src/tools/pgindent/typedefs.list