]> granicus.if.org Git - postgresql/commit
Disable -faggressive-loop-optimizations in gcc 4.8+ for pre-9.2 branches.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 21 Aug 2013 22:31:48 +0000 (18:31 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 21 Aug 2013 22:31:48 +0000 (18:31 -0400)
commit649839dd9f1c08b7aadb654587edd9f86a3caa3f
treef13567bedf6f85614cd92468c8445f2ea3b81b59
parenta2e66c03a4cc3d300e743930ffcc903ee786ffd5
Disable -faggressive-loop-optimizations in gcc 4.8+ for pre-9.2 branches.

With this optimization flag enabled, recent versions of gcc can generate
incorrect code that assumes variable-length arrays (such as oidvector)
are actually fixed-length because they're embedded in some larger struct.
The known instance of this problem was fixed in 9.2 and up by commit
8137f2c32322c624e0431fac1621e8e9315202f9 and followon work, which hides
actually-variable-length catalog fields from the compiler altogether.
And we plan to gradually convert variable-length fields to official
"flexible array member" notation over time, which should prevent this type
of bug from reappearing as gcc gets smarter.  We're not going to try to
back-port those changes into older branches, though, so apply this
band-aid instead.

Andres Freund
configure
configure.in