]> granicus.if.org Git - postgresql/commit
Build HashState's hashkeys expression with the correct parent.
authorAndres Freund <andres@anarazel.de>
Wed, 7 Nov 2018 17:25:54 +0000 (09:25 -0800)
committerAndres Freund <andres@anarazel.de>
Wed, 7 Nov 2018 17:25:54 +0000 (09:25 -0800)
commit5f32b29c18195299e90c1fb6c8945e9a46d772d2
tree344f2e11da1804a2fdaac3fb019d590c1ecfad42
parentda906766cd3bef8290db25bd5c8776c03689f3d5
Build HashState's hashkeys expression with the correct parent.

Previously the expressions were built with the HashJoinState as a
parent. That's incorrect.

Currently this does not appear to be harmful, but for the upcoming
'slot abstraction' work this proves to be problematic, as the
underlying slot types can differ between Hash and HashJoin.  It's
possible that this already causes a problem, but I've not been able to
come up with a scenario.  Therefore don't backpatch at this point.

Author: Andres Freund
Discussion: https://postgr.es/m/20180220224318.gw4oe5jadhpmcdnm@alap3.anarazel.de
src/backend/executor/nodeHashjoin.c