]> granicus.if.org Git - postgresql/commit
Add missing and dangling downlink checks to amcheck
authorTeodor Sigaev <teodor@sigaev.ru>
Wed, 25 Apr 2018 15:02:55 +0000 (18:02 +0300)
committerTeodor Sigaev <teodor@sigaev.ru>
Wed, 25 Apr 2018 15:02:55 +0000 (18:02 +0300)
commit4eaf7eaccb291f5d32d9f05284bfca9c5744de9a
treec4f4ef2c28d23aad6e4b50463a5ac037cbdbf6cc
parent7f58f666cdeee8016fd4ec7aa79629c983ecc3bd
Add missing and dangling downlink checks to amcheck

When bt_index_parent_check() is called with the heapallindexed option,
allocate a second Bloom filter to fingerprint block numbers that appear
in the downlinks of internal pages.  Use Bloom filter probes when
walking the B-Tree to detect missing downlinks.  This can detect subtle
problems with page deletion/VACUUM, such as corruption caused by the bug
just fixed in commit 6db4b499.

The downlink Bloom filter is bound in size by work_mem.  Its optimal
size is typically far smaller than that of the regular heapallindexed
Bloom filter, especially when the index has high fan-out.

Author: Peter Geoghegan
Reviewer: Teodor Sigaev
Discussion: https://postgr.es/m/CAH2-WznUzY4fWTjm1tBB3JpVz8cCfz7k_qVp5BhuPyhivmWJFg@mail.gmail.com
contrib/amcheck/verify_nbtree.c
doc/src/sgml/amcheck.sgml