]> granicus.if.org Git - php/commit
Move acinclude.m4 to build/php.m4
authorPeter Kokot <peterkokot@gmail.com>
Tue, 12 Mar 2019 23:25:07 +0000 (00:25 +0100)
committerPeter Kokot <peterkokot@gmail.com>
Tue, 23 Apr 2019 18:28:45 +0000 (20:28 +0200)
commit4e7064d173d2b5b22e159fcf52d22b10213b67b8
tree3741ce291c096fa1cf990bf98a5010f5bac65adc
parent96a9fb20522fd92295b6191ff57deaa671f0bea5
Move acinclude.m4 to build/php.m4

The acinclude.m4 file is in a usual Autotools build processed with
Automake's aclocal tool. Since PHP currently doesn't use Automake and
aclocal this file can be moved into the build directory. PHP build
system currently generates a combined aclocal.m4 file that Autoconf
can processes automatically.

However, a newer practice is writing all local macros in separate
dedicated files prefixed with package name, in PHP's case PHP_MACRO_NAME
and putting them in a common `m4` directory. PHP uses currently `build`
directory for this purpose.

Name `php.m4` probably most resembles such file for PHP's case.

PHP manually created the aclocal.m4 file from acinclude.m4 and
build/libtool.m4. Which is also not a particularly good practice [1], so
this patch also removes the generated alocal.m4 usage and uses
m4_include() calls manually in the configure.ac and phpize.m4 files
manually.

- sort order is not important but can be alphabetical
- list of *.m4 files prerequisites for configure script generation
  updated
- Moving m4_include() before AC_INIT also removes all comments starting
  with hash character (`#`) in the included files.

[1] https://autotools.io/autoconf/macros.html
.gitignore
build/build.mk
build/php.m4 [moved from acinclude.m4 with 99% similarity]
buildconf
configure.ac
docs/unix-build-system.md
scripts/Makefile.frag
scripts/phpize.in
scripts/phpize.m4