]> granicus.if.org Git - postgresql/commit
Don't fall off the end of perl functions
authorAndrew Dunstan <andrew@dunslane.net>
Sun, 27 May 2018 13:08:42 +0000 (09:08 -0400)
committerAndrew Dunstan <andrew@dunslane.net>
Sun, 27 May 2018 13:08:42 +0000 (09:08 -0400)
commit3a7cc727c7c502353dbb730a0db793abec4de44b
treec140b2974559d0a13d98c132ae52f7d0992aff95
parent8a56ff484808e9c05df9656cf4244229e8c7960d
Don't fall off the end of perl functions

This complies with the perlcritic policy
Subroutines::RequireFinalReturn, which is a severity 4 policy. Since we
only currently check at severity level 5, the policy is raised to that
level until we move to level 4 or lower, so that any new infringements
will be caught.

A small cosmetic piece of tidying of the pgperlcritic script is
included.

Mike Blackwell

Discussion: https://postgr.es/m/CAESHdJpfFm_9wQnQ3koY3c91FoRQsO-fh02za9R3OEMndOn84A@mail.gmail.com
47 files changed:
contrib/bloom/t/001_wal.pl
contrib/intarray/bench/create_test.pl
src/backend/catalog/Catalog.pm
src/backend/catalog/genbki.pl
src/backend/parser/check_keywords.pl
src/backend/utils/mb/Unicode/convutils.pm
src/backend/utils/sort/gen_qsort_tuple.pl
src/bin/pg_archivecleanup/t/010_pg_archivecleanup.pl
src/bin/pg_rewind/RewindTest.pm
src/bin/pg_rewind/t/001_basic.pl
src/bin/pg_rewind/t/002_databases.pl
src/bin/pg_rewind/t/003_extrafiles.pl
src/bin/pg_rewind/t/004_pg_xlog_symlink.pl
src/bin/pgbench/t/001_pgbench_with_server.pl
src/bin/pgbench/t/002_pgbench_no_server.pl
src/include/catalog/reformat_dat_file.pl
src/interfaces/ecpg/preproc/parse.pl
src/pl/plperl/plc_perlboot.pl
src/pl/plperl/text2macro.pl
src/test/authentication/t/001_password.pl
src/test/authentication/t/002_saslprep.pl
src/test/kerberos/t/001_auth.pl
src/test/ldap/t/001_auth.pl
src/test/perl/PostgresNode.pm
src/test/perl/SimpleTee.pm
src/test/perl/TestLib.pm
src/test/recovery/t/001_stream_rep.pl
src/test/recovery/t/003_recovery_targets.pl
src/test/recovery/t/007_sync_rep.pl
src/test/recovery/t/009_twophase.pl
src/test/ssl/ServerSetup.pm
src/tools/copyright.pl
src/tools/git_changelog
src/tools/msvc/Install.pm
src/tools/msvc/MSBuildProject.pm
src/tools/msvc/Mkvcbuild.pm
src/tools/msvc/Project.pm
src/tools/msvc/Solution.pm
src/tools/msvc/VCBuildProject.pm
src/tools/msvc/builddoc.pl
src/tools/msvc/gendef.pl
src/tools/msvc/vcregress.pl
src/tools/pginclude/pgcheckdefines
src/tools/pgindent/pgindent
src/tools/pgperlcritic/perlcriticrc
src/tools/pgperlcritic/pgperlcritic
src/tools/version_stamp.pl