]> granicus.if.org Git - postgresql/commit
Fix more format truncation issues
authorPeter Eisentraut <peter_e@gmx.net>
Thu, 15 Mar 2018 15:10:41 +0000 (11:10 -0400)
committerPeter Eisentraut <peter_e@gmx.net>
Thu, 15 Mar 2018 15:41:42 +0000 (11:41 -0400)
commit3a4b891964a531aa7d242a48fcd9e41379863ead
treecda1cef77f04c277d8001bf3049b3366b551b4e5
parent648a6c7bd815f98b35709bd56f9f1ca276b33ae6
Fix more format truncation issues

Fix the warnings created by the compiler warning options
-Wformat-overflow=2 -Wformat-truncation=2, supported since GCC 7.  This
is a more aggressive variant of the fixes in
6275f5d28a1577563f53f2171689d4f890a46881, which GCC 7 warned about by
default.

The issues are all harmless, but some dubious coding patterns are
cleaned up.

One issue that is of external interest is that BGW_MAXLEN is increased
from 64 to 96.  Apparently, the old value would cause the bgw_name of
logical replication workers to be truncated in some circumstances.

But this doesn't actually add those warning options.  It appears that
the warnings depend a bit on compilation and optimization options, so it
would be annoying to have to keep up with that.  This is more of a
once-in-a-while cleanup.

Reviewed-by: Michael Paquier <michael@paquier.xyz>
14 files changed:
contrib/pgstattuple/pgstattuple.c
src/backend/commands/explain.c
src/backend/libpq/be-secure-openssl.c
src/backend/utils/adt/dbsize.c
src/backend/utils/adt/float.c
src/backend/utils/adt/formatting.c
src/backend/utils/misc/guc.c
src/bin/initdb/initdb.c
src/bin/pg_dump/pg_backup_archiver.c
src/bin/pg_dump/pg_backup_tar.c
src/bin/pgbench/pgbench.c
src/include/postmaster/bgworker.h
src/interfaces/libpq/fe-secure-openssl.c
src/pl/tcl/pltcl.c