]> granicus.if.org Git - postgresql/commit
Fix gin_leafpage_items().
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 4 Nov 2016 16:11:47 +0000 (12:11 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 4 Nov 2016 16:11:54 +0000 (12:11 -0400)
commit367b99bbb13a14bd96bba6f73c231b2056ba9592
tree7ddb1153a4ee6807b21de76c0b92d63718738eed
parent927d7bb6b120a2ca09a164898f887eb850b7a329
Fix gin_leafpage_items().

On closer inspection, commit 84ad68d64 broke gin_leafpage_items(),
because the aligned copy of the page got palloc'd in a short-lived
context whereas it needs to be in the SRF's multi_call_memory_ctx.
This was not exposed by the regression test, because the regression
test doesn't actually exercise the function in a meaningful way.
Fix the code bug, and extend the test in what I hope is a portable
fashion.
contrib/pageinspect/expected/gin.out
contrib/pageinspect/ginfuncs.c
contrib/pageinspect/sql/gin.sql